Make sure LSP notification message is wrapped #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by long standing SWT issue ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=194758 ) but easily workaroundable as done in this patch. Some minor SonarLint warnings are also fixed. Fixes eclipse-lsp4e#220 .
|
@rubenporras Please verify this fixes the issue for you, it was good enough in my tests. |
|
@akurtakov , yes, it fixes it for me as well. Thanks. I merge it since I think the test is a wrong positive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by long standing SWT issue (
https://bugs.eclipse.org/bugs/show_bug.cgi?id=194758 ) but easily
workaroundable as done in this patch.
Some minor SonarLint warnings are also fixed.
Fixes #220 .